Skip to content

Convert visit method to an arrow function #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented May 2, 2020

Issue #, if available:
Similar to #163

Description of changes:

  • Converts visit method to an arrow function
  • Arrow functions are preferred over classic function expression because of their verbosity, and lexical binding

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Contributor Author

trivikr commented May 2, 2020

CodeGen PR: aws/aws-sdk-js-v3#1132

@trivikr trivikr merged commit acaa058 into smithy-lang:master May 5, 2020
@trivikr trivikr deleted the visit-arrow-function branch May 5, 2020 00:38
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants