Skip to content

Commit acaa058

Browse files
authored
Convert visit method to an arrow function (#173)
1 parent 0b146f3 commit acaa058

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/UnionGenerator.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,10 @@
9292
* bear: (value: Bear) => T;
9393
* _: (name: string, value: any) => T;
9494
* }
95-
* export function visit<T>(
95+
* export const visit = <T>(
9696
* value: Attacker,
9797
* visitor: Visitor<T>
98-
* ): T {
98+
* ): T => {
9999
* if (value.lion !== undefined) return visitor.lion(value.lion);
100100
* if (value.tiger !== undefined) return visitor.tiger(value.tiger);
101101
* if (value.bear !== undefined) return visitor.bear(value.bear);
@@ -193,10 +193,10 @@ private void writeVisitorType() {
193193

194194
private void writeVisitorFunction() {
195195
// Create the visitor dispatcher for the union.
196-
writer.write("export function visit<T>(").indent();
196+
writer.write("export const visit = <T>(").indent();
197197
writer.write("value: $L,", symbol.getName());
198198
writer.write("visitor: Visitor<T>");
199-
writer.dedent().write("): T {").indent();
199+
writer.dedent().write("): T => {").indent();
200200
for (MemberShape member : shape.getAllMembers().values()) {
201201
String memberName = symbolProvider.toMemberName(member);
202202
writer.write("if (value.${1L} !== undefined) return visitor.$1L(value.${1L});", memberName);

smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/UnionGeneratorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,10 @@ public void generatesTaggedUnions() {
8585
+ " }"));
8686

8787
// It generates the actual visitor function.
88-
assertThat(output, containsString("export function visit<T>(\n"
88+
assertThat(output, containsString("export const visit = <T>(\n"
8989
+ " value: Example,\n"
9090
+ " visitor: Visitor<T>\n"
91-
+ " ): T {\n"
91+
+ " ): T => {\n"
9292
+ " if (value.A !== undefined) return visitor.A(value.A);\n"
9393
+ " if (value.B !== undefined) return visitor.B(value.B);\n"
9494
+ " if (value.C !== undefined) return visitor.C(value.C);\n"

0 commit comments

Comments
 (0)