[WIP] Convert to bundles directory structure #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create `/bundles/Comments` folder structure Update webpack config files to reflect the change
Rename stores folder to store Fix components path in specs Fix `getDOMNode` warning on `CommentForm.jsx`
| author: this.refs.inlineAuthor.getDOMNode().value, | ||
| text: this.refs.inlineText.getDOMNode().value, | ||
| author: this.refs.inlineAuthor.value, | ||
| text: this.refs.inlineText.value, |
There was a problem hiding this comment.
This fixes a warning from React 0.14.
|
LGTM! |
justin808
added a commit
that referenced
this pull request
Dec 7, 2015
[WIP] Convert to bundles directory structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work with @MaMute to get #154 working.
Update
react_on_railsgem to 1.1.1Create
/bundles/Commentsfolder structureUpdate webpack config files to bundles directory structure
Rename
/storesfolder to/storeFix
getDOMNode()warning onCommentForm.jsx