Skip to content

Del jquery-ujs from webpack.client.base.config.js #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2015

Conversation

justin808
Copy link
Member

jquery-ujs is not needed for the Webpack Dev Server setup.

@justin808
Copy link
Member Author

I reported the lint issue: jsx-eslint/eslint-plugin-react#345

@justin808 justin808 force-pushed the jquery-ujs-only-rails branch 2 times, most recently from d7a21a6 to d52f280 Compare December 8, 2015 08:19
@justin808
Copy link
Member Author

@josiasds @dylangrafmyre What’s the best way to troubleshoot this: https://travis-ci.org/shakacode/react-webpack-rails-tutorial/builds/95525391

Passes locally for me:

~/shakacode/react-webpack-rails-tutorial (jquery-ujs-only-rails u=) rake ci                                                                                                                                                                    [22:19:04]
Running Rubocop Linters via `rubocop -S -D .`
rubocop -S -D .
Warning: Deprecated pattern style '/Users/justin/shakacode/react-webpack-rails-tutorial/client/node_modules/**/*' in /Users/justin/shakacode/react-webpack-rails-tutorial/.rubocop.yml
^[[1;9DInspecting 36 files
....................................

36 files inspected, no offenses detected
Running ruby-lint Linters via `ruby-lint app config spec lib`
ruby-lint app config spec lib
Running eslint via `cd client && npm run eslint . -- --ext .jsx,.js`
cd client && npm run eslint . -- --ext .jsx,.js

> [email protected] eslint /Users/justin/shakacode/react-webpack-rails-tutorial/client
> eslint --ext .js,.jsx . "." "--ext" ".jsx,.js"

Running jscs via `cd client && npm run jscs .`
cd client && npm run jscs .

> [email protected] jscs /Users/justin/shakacode/react-webpack-rails-tutorial/client
> jscs --verbose . "."

Completed running all JavaScript Linters
scss-lint found no lints
Completed all linting
Running security audit on gems (bundle_audit)
Running security audit on code (brakeman)
brakeman --exit-on-warn --quiet -A -z

+BRAKEMAN REPORT+

Application path: /Users/justin/shakacode/react-webpack-rails-tutorial
Rails version: 4.2.5
Brakeman version: 3.1.2
Started at 2015-12-07 22:56:12 -1000
Duration: 0.208044 seconds
Checks run: BasicAuth, ContentTag, CreateWith, CrossSiteScripting, DefaultRoutes, Deserialize, DetailedExceptions, DigestDoS, EscapeFunction, Evaluation, Execute, FileAccess, FileDisclosure, FilterSkipping, ForgerySetting, HeaderDoS, I18nXSS, JRubyXML, JSONEncoding, JSONParsing, LinkTo, LinkToHref, MailTo, MassAssignment, ModelAttrAccessible, ModelAttributes, ModelSerialize, NestedAttributes, NumberToCurrency, QuoteTableName, Redirect, RegexDoS, Render, RenderDoS, RenderInline, ResponseSplitting, SQL, SQLCVEs, SSLVerify, SafeBufferManipulation, SanitizeMethods, SelectTag, SelectVulnerability, Send, SendFile, SessionManipulation, SessionSettings, SimpleFormat, SingleQuotes, SkipBeforeFilter, StripTags, SymbolDoS, SymbolDoSCVE, TranslateBug, UnsafeReflection, UnscopedFind, ValidationRegex, WeakHash, WithoutProtection, XMLDoS, YAMLParsing


+SUMMARY+

+-------------------+-------+
| Scanned/Reported  | Total |
+-------------------+-------+
| Controllers       | 3     |
| Models            | 2     |
| Templates         | 10    |
| Errors            | 0     |
| Security Warnings | 0 (0) |
+-------------------+-------+



PASSED

@justin808 justin808 force-pushed the jquery-ujs-only-rails branch from d52f280 to b681f48 Compare December 8, 2015 09:00
@@ -64,7 +64,7 @@
"webpack": "^1.12.8"
},
"devDependencies": {
"babel-eslint": "^4.1.5",
"babel-eslint": "^5.0.0-beta4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 version 5.0.0-beta4 uses Babel 6. Maybe this is causing some conflicts and failing the build? babel/babel-eslint@a4c09a8

jquery-ujs is not needed for the Webpack Dev Server setup.
fix linter issue
@justin808 justin808 force-pushed the jquery-ujs-only-rails branch from b681f48 to 47d1d08 Compare December 8, 2015 20:18
@josiasds
Copy link
Member

josiasds commented Dec 9, 2015

@justin808 I believe it was a conflict when merging this with #171, where we created the bundles directory. Fixed now.

@dylangrafmyre Thanks for the tip on Slack!

justin808 added a commit that referenced this pull request Dec 9, 2015
Del jquery-ujs from webpack.client.base.config.js
@justin808 justin808 merged commit ee769cd into master Dec 9, 2015
@justin808
Copy link
Member Author

Thanks @josiasds! Please be sure the webpack dev server mode works as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants