Skip to content

"Edit on GitHub" link broken #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oliverklee opened this issue Apr 26, 2019 · 3 comments · Fixed by #171
Closed

"Edit on GitHub" link broken #128

oliverklee opened this issue Apr 26, 2019 · 3 comments · Fixed by #171

Comments

@oliverklee
Copy link
Contributor

This issue probably is related to #41 (i.e., it probably blocks it).

Steps to reproduce:

  1. go to https://phpunit.readthedocs.io/en/8.0/ (which is the English version of the docs)
  2. at the bottom of the left sidebar, select any of the following branches: 7.1., 7.2., 7.3., 7.4, 7.5, 8.0
  3. click on the "Edit on GitHub" link at the top of the page

Expected results:
The corresponding file on GitHub, and a URL like this:
https://github.com/sebastianbergmann/phpunit-documentation-english/blob/7.0/src/index.rst

Actual results:
A page that has the text "Not found" on it, and a URL like this:
https://github.com/sebastianbergmann/phpunit-documentation-english//7.1/src/index.rst

Apart from the different version number, the most striking difference seems to be that the broken URLs are missing the "blob" segment. Adding that segment to the broken URL makes it work fine.

With version 7.0, the Edit link is fine. Starting with 7.1, the problem occurs.

@sebastianbergmann
Copy link
Owner

Looks like readthedocs/readthedocs.org#5303 to me.

@oliverklee
Copy link
Contributor Author

Does this mean this will be fixed automatically the next time the docs are published?

@sebastianbergmann
Copy link
Owner

I hope so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants