Skip to content

The "Edit on GitHub" links do not work on Read the Docs for es, fr, pt, ja and zh languages #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dzc34 opened this issue Apr 18, 2018 · 6 comments

Comments

@dzc34
Copy link
Contributor

dzc34 commented Apr 18, 2018

The "Edit on GitHub" links do not work on Read the Docs for es, fr, pt, ja and zh languages

ex:
https://phpunit.readthedocs.io/ja/latest/

https://github.com/sebastianbergmann/phpunit-documentation-japanese//master/src/index.rst

@sebastianbergmann
Copy link
Owner

I am not sure what I can/should do about this. @belanur?

@sebastianheuer
Copy link
Collaborator

This is also the case for the English master version (which is hidden to regular users): http://phpunit.readthedocs.io/en/master/

It seems the link works with versions that are based on branches as tags, so I would assume that configuring the translations the same way as the English documentation would lead to working links. This is how the setup looks like on readthedocs.org:
screenshot 2018-04-19 09 58 57

@keradus
Copy link
Contributor

keradus commented Apr 19, 2018

-https://github.com/sebastianbergmann/phpunit-documentation-japanese//master/src/index.rst
+https://github.com/sebastianbergmann/phpunit-documentation-japanese/blob/master/src/index.rst

(see missing blob)

@sebastianbergmann
Copy link
Owner

Sorry, but I am still not sure what I should do about this.

Do I understand correctly, @belanur, that I need to change the ReadTheDocs configuration and that this is a one-time change and not something that needs to be done every time there is a new branch?

Besides that, I would like to have the translation teams create/maintain the version-specific branches. I will do that for the English edition.

@joachim-n
Copy link
Contributor

@sebastianbergmann
Copy link
Owner

The PHPUnit project does not have the resources to coordinate the translation of the PHPUnit documentation into other languages. Some, if not most, of the existing translations have not been up-to-date with the English documentation for quite a while. I have therefore decided to no longer officially support documentation languages other than English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants