Categoricalimputer improvements #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dukebody
force-pushed
the
categoricalimputer-improvements
branch
from
4c68601 to
5eb6c50
Compare
dukebody
force-pushed
the
categoricalimputer-improvements
branch
from
5eb6c50 to
e0d7c00
Compare
|
Rebased over flake8 fixes. |
arnau126
reviewed
Apr 18, 2017
|
|
||
| modes = pd.Series(X).mode() | ||
| if modes.shape[0] == 0: | ||
| raise ValueError('No value is repeteated more than ' |
There was a problem hiding this comment.
Typo: repeteated -> repeated.
arnau126
reviewed
Apr 18, 2017
| modes = pd.Series(X).mode() | ||
| if modes.shape[0] == 0: | ||
| raise ValueError('No value is repeteated more than ' | ||
| 'twice in the column') |
There was a problem hiding this comment.
Looking at pandas doc, I think that should be:
"No value is repeated more than once in the column."
or
"No value is repeated at least twice in the column"
|
About
seems like no longer will be a problem in pandas 0.20.0 since they will change |
|
Not sure. The issue discussed seems to be about the mode of a Series with
only one item. What will be the behavior when there are multiple items but
none of them appears more than once?
2017-04-19 10:45 GMT+02:00 Arnau <[email protected]>:
… About
CategoricalImputer: Error out when no mode is found
seems like no longer will be a problem in pandas 0.20.0 since they will
change mode behavior to always return at least one value:
pandas-dev/pandas#15744 <pandas-dev/pandas#15744>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#89 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACj4Spuups51NZp0vqcoWOZ4_FlMrrOks5rxcmdgaJpZM4M_BbA>
.
|
|
Self-answer: From the tests I understand that if there are multiple items
and none appears more than once then the mode will be an array with all the
items, inversely sorted.
2017-04-19 10:50 GMT+02:00 Israel Saeta Pérez <[email protected]>:
… Not sure. The issue discussed seems to be about the mode of a Series with
only one item. What will be the behavior when there are multiple items but
none of them appears more than once?
2017-04-19 10:45 GMT+02:00 Arnau ***@***.***>:
> About
>
> CategoricalImputer: Error out when no mode is found
>
> seems like no longer will be a problem in pandas 0.20.0 since they will
> change mode behavior to always return at least one value:
> pandas-dev/pandas#15744 <pandas-dev/pandas#15744>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#89 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AACj4Spuups51NZp0vqcoWOZ4_FlMrrOks5rxcmdgaJpZM4M_BbA>
> .
>
|
dukebody
force-pushed
the
categoricalimputer-improvements
branch
from
e0d7c00 to
5ce407c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #87 with a minor fix.
Enhancements:
CategoricalImputeralso inherits fromBaseEstimator.missing_valuesparam: to specify which is the placeholder for the missing values.copyparam: to specify whether to perfom the imputation in a copy ofXor inplace.yparam in fit forPipelinecompatibility.NotFittedErrorin transform if the imputer was not previously fitted.Fix bugs: