-
Notifications
You must be signed in to change notification settings - Fork 415
Bug in a CategorialImputer test. #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CategorialImputer tests are not actually testing the feature when
input_type is 'np'
andnone_value is np.nan
.This is because of the use of
np.asarray
. This function infers the data type and in this case it is casting the np.nan to string.In explanation:
So, in this case, there is no null-like value and the imputer is doing nothing.
The text was updated successfully, but these errors were encountered: