-
Notifications
You must be signed in to change notification settings - Fork 36
chore: update to cmake 3.19.1 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution 🙏
The failed Travis macos amd64 job has been manually restarted. Note: We will have to either improve the speed of the build or move away from Travis. An option would be to transition to GitHub action. I am working in that direction in the context of an other project and will integrate changes here once done. |
If possible, I'd highly recommend cibuildwheel. I don't know (yet) how to use it to build for ARM and PowerPC on GHA (still am using Travis for that), but it works very well and is mostly agnostic to CI systems. |
3.19.2 released. |
The change from a x86 to universal2 installer for macOS changes things - but I was able to update this to 3.19.1. The 3.19.2 update will be more challenging since only universal2 files are provided, and maybe this should be accompanied by a universal2 wheel too (see pypa/cibuildwheel#484 and matching issue; I'll understand what needs to be done a bit better once that's going). |
cibuildwheel 1.9.0 came out yesterday, with support for Universal2 and Arm wheels cross-compiled from the normal Intel 10.15 runners. 1.8.0 had emulation support for Arm, PowerPC, and the other arch (z something?) for Linux runners. |
d6913db
to
d47ad46
Compare
d47ad46
to
b238744
Compare
You got the CI working, great! Next will be to work on 3.20 and the rename. As long as the CI is working, that should be pretty easy to do, I think. |
I apologize, I think I may be misunderstanding things. I was watching both this issue / the one mentioning upgrading to 3.20 to see when they were going to get updated on pypi. From what I could understand it looked like 3.19/3.20 should both be released and available on pypi. However, I see that as still showing 3.18.4.post1: https://pypi.org/project/cmake/#history Are there plans to update pypi in the future? |
Currently this has not been tagged and released to PyPI yet. I think we are basically ready; universal2 support, alternate Linux arch support, and single-binary support are all in. @jcfr, is there anything left before releasing? We can always do a post1 release if we have to. :) Anyway, I'm leaving releases up to @jcfr. @mayeut do any of these need to still be applied to ninja-python-distributions? |
Yes, universal2 support, alternate Linux arch support, and single-binary support are not in the ninja-python-distributions (except for linux aarch64). You can ping me there if you want me to try and do the same thing (not planning PRs there before CMake is released because of the CMake dependency in Ninja). |
#114 has been updated and would be nice to include in 3.19.1's release, too. #117 looks safe to me, too.