Skip to content

chore: update to cmake 3.19.1 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2021

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Nov 23, 2020

#114 has been updated and would be nice to include in 3.19.1's release, too. #117 looks safe to me, too.

Copy link
Contributor

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🙏

@jcfr
Copy link
Contributor

jcfr commented Nov 23, 2020

The failed Travis macos amd64 job has been manually restarted.

Note: We will have to either improve the speed of the build or move away from Travis. An option would be to transition to GitHub action. I am working in that direction in the context of an other project and will integrate changes here once done.

@henryiii
Copy link
Contributor Author

If possible, I'd highly recommend cibuildwheel. I don't know (yet) how to use it to build for ARM and PowerPC on GHA (still am using Travis for that), but it works very well and is mostly agnostic to CI systems.

@gengjiawen
Copy link

3.19.2 released.

@henryiii
Copy link
Contributor Author

The change from a x86 to universal2 installer for macOS changes things - but I was able to update this to 3.19.1. The 3.19.2 update will be more challenging since only universal2 files are provided, and maybe this should be accompanied by a universal2 wheel too (see pypa/cibuildwheel#484 and matching issue; I'll understand what needs to be done a bit better once that's going).

@henryiii henryiii changed the title chore: update to cmake 3.19.0 chore: update to cmake 3.19.1 Dec 18, 2020
@henryiii
Copy link
Contributor Author

@jcfr would it be a good idea to go ahead with this PR, plus maybe #114 and #117, then start working on the 3.19.2 update and possibly adding universal2 wheels? (For the reasons listed in the issue, I think we should also still provide a classic wheel for now too).

@henryiii
Copy link
Contributor Author

henryiii commented Feb 6, 2021

cibuildwheel 1.9.0 came out yesterday, with support for Universal2 and Arm wheels cross-compiled from the normal Intel 10.15 runners. 1.8.0 had emulation support for Arm, PowerPC, and the other arch (z something?) for Linux runners.

@henryiii
Copy link
Contributor Author

@jcfr would you like to do this PR, #114, and #117, and then we can work on adding Universal2 support and supporting more recent releases?

@jcfr jcfr force-pushed the update-to-cmake-3.19.0 branch from d47ad46 to b238744 Compare April 9, 2021 09:24
@jcfr jcfr merged commit ca5ee1c into scikit-build:master Apr 9, 2021
@henryiii
Copy link
Contributor Author

henryiii commented Apr 9, 2021

You got the CI working, great! Next will be to work on 3.20 and the rename. As long as the CI is working, that should be pretty easy to do, I think.

@jcfr
Copy link
Contributor

jcfr commented Apr 9, 2021

got the CI working, great!

Credits goes to @mayeut 🙏

Next will be to work on 3.20

👌

In the mean time, will also address #126 and release wheels 3.19.1

and the rename

See #132

@henryiii
Copy link
Contributor Author

henryiii commented Apr 9, 2021

In the mean time, will also address

Yes, already opened #133 for it. :)

Thanks @mayeut then!

@henryiii henryiii deleted the update-to-cmake-3.19.0 branch April 9, 2021 15:36
@krismalfettone
Copy link

I apologize, I think I may be misunderstanding things. I was watching both this issue / the one mentioning upgrading to 3.20 to see when they were going to get updated on pypi. From what I could understand it looked like 3.19/3.20 should both be released and available on pypi. However, I see that as still showing 3.18.4.post1: https://pypi.org/project/cmake/#history

Are there plans to update pypi in the future?

@henryiii
Copy link
Contributor Author

Currently this has not been tagged and released to PyPI yet. I think we are basically ready; universal2 support, alternate Linux arch support, and single-binary support are all in. @jcfr, is there anything left before releasing? We can always do a post1 release if we have to. :) Anyway, I'm leaving releases up to @jcfr. @mayeut do any of these need to still be applied to ninja-python-distributions?

@mayeut
Copy link
Contributor

mayeut commented May 17, 2021

do any of these need to still be applied to ninja-python-distributions?

Yes, universal2 support, alternate Linux arch support, and single-binary support are not in the ninja-python-distributions (except for linux aarch64). You can ping me there if you want me to try and do the same thing (not planning PRs there before CMake is released because of the CMake dependency in Ninja).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants