Skip to content

Universal2 wheel on macOS #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henryiii opened this issue Apr 9, 2021 · 3 comments · Fixed by #135
Closed

Universal2 wheel on macOS #132

henryiii opened this issue Apr 9, 2021 · 3 comments · Fixed by #135

Comments

@henryiii
Copy link
Contributor

henryiii commented Apr 9, 2021

We need to produce a universal wheel with CMake 3.19.2+ (probably will just work on 3.20). We still need a non-universal2 wheel too, since older pips can't download a universal2 wheel. There were also renames as part of the 3.20 release, so those will need to get updated on upgrade to 3.20, too.

@jcfr
Copy link
Contributor

jcfr commented Apr 9, 2021

There were also renames as part of the 3.20 release

Do we have references to these ?

@henryiii
Copy link
Contributor Author

henryiii commented Apr 9, 2021

Last two bullets of https://cmake.org/cmake/help/latest/release/3.20.html#other-changes . For linux, the L in the filename was changed to l. :) Not sure how much Windows changed.

@henryiii
Copy link
Contributor Author

henryiii commented Apr 9, 2021

And, of course, macOS had already changed to the universal2 name in 3.19.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants