Skip to content

Fix #62: Do not tag some classes as storage keywords #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

nicolasstucki
Copy link
Contributor

Avoid coloring Unit, Boolean, Byte, Char, Short, Int, Float, Long, Double, String and Symbol as keywords. Use the same color for all types and companion object references.

Note that keyworks are in blue and types are in green(ish).

Old
Screenshot 2019-09-25 at 12 03 58

With this PR
Screenshot 2019-09-25 at 11 59 00

@liufengyun
Copy link

@nicolasstucki The CI is not happy.

@nicolasstucki
Copy link
Contributor Author

@liufengyun CI passes now

Copy link

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do coloring Unit, Boolean, Byte, Char, Short, Int, Float, Long, Double, String, Nil, None, Symbol and self with colors that do not represent their semantics.
@nicolasstucki
Copy link
Contributor Author

Squashed and rebased

@nicolasstucki nicolasstucki merged commit e682d95 into scala:master Oct 7, 2019
@nicolasstucki nicolasstucki deleted the fix-#62 branch October 7, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants