Skip to content

Do not highlight some types as keywords #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolasstucki opened this issue Sep 24, 2019 · 3 comments
Closed

Do not highlight some types as keywords #62

nicolasstucki opened this issue Sep 24, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@nicolasstucki
Copy link
Contributor

Currently Unit, Boolean, Byte, Char, Short, Int, Float, Long, Double, String and Symbol are colored as keywords. When written down it look like there is an error in the code. We should highlight them as types instead for homogeneity.

@nicolasstucki nicolasstucki added the enhancement New feature or request label Sep 24, 2019
nicolasstucki added a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Sep 25, 2019
@nicolasstucki
Copy link
Contributor Author

For example in Symbol.scala#L33

Screenshot 2019-09-25 at 12 16 45

the Symbol appears as a keyword. One could argue that this is highlighted as a scala.Symbol "primitive" but it is not as this symbol is defined that same file. It is impossible to distinguish them syntactically, only the language server could take the decision to display them with a specific style.

@martijnhoekstra
Copy link

if this is done, maybe self should stop being shown as a keyword too -- it's the reasoning of "not a keyword but sort of" as these I think.

@nicolasstucki
Copy link
Contributor Author

Same for None and Nil

nicolasstucki added a commit that referenced this issue Oct 7, 2019
Fix #62: Do not tag some classes as storage keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants