Skip to content

Fix bug with // inside of a block comment breaking highlighting #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

PanAeon
Copy link
Contributor

@PanAeon PanAeon commented Jun 26, 2019

Fixes #39. I factored out block comments, so the // won't be treated as a line comment within them. Added a unit test.

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for the quick fix!

Heads up. I am going on vacation after today and don't expect to respond much on GitHub until ~mid-August. Feel free merge your own PRs and cut new releases.

@olafurpg olafurpg merged commit fbce6dd into scala:master Jun 28, 2019
@PanAeon
Copy link
Contributor Author

PanAeon commented Jun 28, 2019

@olafurpg, have a great time off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single line block comments with embedded url fail to parse correctly
2 participants