Skip to content

Single line block comments with embedded url fail to parse correctly #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CloudNiner opened this issue Jun 25, 2019 · 1 comment · Fixed by #40
Closed

Single line block comments with embedded url fail to parse correctly #39

CloudNiner opened this issue Jun 25, 2019 · 1 comment · Fixed by #40

Comments

@CloudNiner
Copy link

CloudNiner commented Jun 25, 2019

vscode-scala-syntax version: 0.3.3

A block comment on a single line of the form:

/** https://github.com/scala/vscode-scala-syntax */

will fail to parse correctly. More specifically as long as the single line block comment has :// highlighting will break:
Screen Shot 2019-06-25 at 4 11 44 PM

Other combinations appear to parse correctly:
Screen Shot 2019-06-25 at 4 11 52 PM
Screen Shot 2019-06-25 at 4 11 32 PM

@PanAeon
Copy link
Contributor

PanAeon commented Jun 26, 2019

Yes, my bad. It's a regression from 0.3.2. 💥 The // symbol inside the block comment gets treated as a line comment and "consumes" the characters */.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants