Skip to content

Fix #141: Remove old extension on syntax #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this!

val language = file.extension(
// ^^^^^^^^^ - keyword.declaration.scala
val language = file extension (
// ^^^^^^^^^ - keyword.declaration.scala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this assert its highlighted as a keyword? I expected it to be highlighted the same as “file”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The - checks that it is not a keyword.declaration.scala

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I'm not so familiar with the testing infrastructure. Great!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discovered that one today. It must be new, I don't remember seeing it in the first version of the testing infrastructure we use.

@nicolasstucki nicolasstucki merged commit ed80f17 into scala:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension token is incorrectly highlighted as keyword instead of identifier
3 participants