Skip to content

Extension token is incorrectly highlighted as keyword instead of identifier #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
olafurpg opened this issue Sep 4, 2020 · 1 comment · Fixed by #142
Closed

Extension token is incorrectly highlighted as keyword instead of identifier #141

olafurpg opened this issue Sep 4, 2020 · 1 comment · Fixed by #142
Labels
bug Something isn't working

Comments

@olafurpg
Copy link
Contributor

olafurpg commented Sep 4, 2020 •
edited
Loading

The extension token is incorrectly highlighted as a keyword in the screenshot below

Screenshot 2020-09-04 at 10 14 05

I expected extension to be highlighted as an identifier. cc/ @nicolasstucki
@olafurpg olafurpg changed the title Extension keyword is incorrectly highlighted Extension token is incorrectly highlighted Sep 4, 2020
@olafurpg olafurpg changed the title Extension token is incorrectly highlighted Extension token is incorrectly highlighted as keyword instead of identifier Sep 4, 2020
@nicolasstucki nicolasstucki added the bug Something isn't working label Sep 7, 2020
@nicolasstucki
Copy link
Contributor

This comes from the old rule to highlight the extension on syntax that has been removed a couple of releases ago. We can just drop the old syntax highlighting.

nicolasstucki added a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Sep 7, 2020
@nicolasstucki
Fix scala#141: Remove old extension on syntax
1d27380
@nicolasstucki nicolasstucki linked a pull request Sep 7, 2020 that will close this issue
Fix #141: Remove old extension on syntax #142
Merged
nicolasstucki added a commit that referenced this issue Sep 7, 2020
@nicolasstucki
Merge pull request #142 from nicolasstucki/fix-#141
ed80f17 
Fix #141: Remove old `extension on` syntax
PanAeon pushed a commit to PanAeon/vscode-scala-syntax that referenced this issue Apr 28, 2022
@nicolasstucki @PanAeon
Fix scala#141: Remove old extension on syntax
5c1ac06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #141: Remove old extension on syntax nicolasstucki/vscode-scala-syntax
2 participants
@olafurpg @nicolasstucki