Fix #75: Add Travis CI deployment to GitHub Releases #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.travis.yml
Outdated
| deploy: | ||
| provider: releases | ||
| skip_cleanup: true | ||
| file: syntaxes/Scala.tmLanguage.json |
There was a problem hiding this comment.
Issue #75 is about the missing .vsix file. The Scala.tmLanguage.json already included in the sources zip artefact.
There was a problem hiding this comment.
I've amended the commit to fix this
MaximeKjaer
force-pushed
the
travis-ci-releases
branch
from
98e993b to
e79e1b5
Compare
nicolasstucki
approved these changes
Jul 19, 2020
|
I'll make a release at some point this week and test this. |
|
I'll keep an eye out, but please do ping me if it crashes |
|
It failed, I had to add the vsix manually to https://github.com/scala/vscode-scala-syntax/releases/tag/0.4.2 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the Travis CI guide for deploying to GitHub releases. I can't really test it, so I guess we'll see at the next release! Worst case, if it fails, it's the last deployment step, and therefore won't affect the previous deployment steps.