Skip to content

Artifacts not published to GitHub releases #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sideeffffect opened this issue Jan 28, 2020 · 6 comments
Closed

Artifacts not published to GitHub releases #75

sideeffffect opened this issue Jan 28, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@sideeffffect
Copy link

sideeffffect commented Jan 28, 2020

The releases pages on GitHub, eg
https://github.com/scala/vscode-scala-syntax/releases/tag/0.3.9
https://github.com/scala/vscode-scala-syntax/releases/tag/0.1.0
don't contain the build artifact, like scala-lang.scala-0.3.9.vsix and scala-lang.scala-snippets-0.1.0.vsix, uploaded and viable there

the vsix files is only available via Microsoft's Marketplace
https://marketplace.visualstudio.com/_apis/public/gallery/publishers/scalameta/vsextensions/metals/1.7.2/vspackage

That is not a viable source for other IDEs.
The scala-lang.scala and scala-lang.scala-snippets vsix files have to be available somewhere else, GitHub releases is probably the best place, so that Metals is officially included in Eclipse Che web IDE.
eclipse-che/che-plugin-registry#356

Related issue: https://github.com/scalameta/metals/issues/1365

@sideeffffect
Copy link
Author

Uploading the artifacts from Travis should be easy
https://docs.travis-ci.com/user/deployment/releases/

@sideeffffect
Copy link
Author

@nicolasstucki could you please have a look at this? it's blocking accepting Scala in Eclipse Che

@nicolasstucki
Copy link
Contributor

I'm a bit swamped this next week. @anatoliykmetyuk could you have a look?

anatoliykmetyuk added a commit to anatoliykmetyuk/vscode-scala-syntax that referenced this issue Mar 5, 2020
anatoliykmetyuk added a commit to anatoliykmetyuk/vscode-scala-syntax that referenced this issue Mar 5, 2020
nicolasstucki added a commit that referenced this issue Mar 11, 2020
Fix #75: Publish vsix files on release
@nicolasstucki nicolasstucki reopened this Mar 11, 2020
@nicolasstucki
Copy link
Contributor

@sideeffffect I added manually the artifact to https://github.com/scala/vscode-scala-syntax/releases/tag/0.3.9

@sideeffffect
Copy link
Author

That's great news, but I don't see it available for the newest release, like 0.3.11. What went wrong?

@nicolasstucki
Copy link
Contributor

The scripts to attached the vsix crashed

@nicolasstucki nicolasstucki added the enhancement New feature or request label Jun 29, 2020
MaximeKjaer pushed a commit to MaximeKjaer/vscode-scala-syntax that referenced this issue Jul 18, 2020
nicolasstucki added a commit that referenced this issue Jul 19, 2020
Fix #75: Add Travis CI deployment to GitHub Releases
@nicolasstucki nicolasstucki reopened this Jul 22, 2020
nicolasstucki added a commit that referenced this issue Aug 5, 2020
Fix #75: Fix Travis CI deployments from branches other than master
PanAeon pushed a commit to PanAeon/vscode-scala-syntax that referenced this issue Apr 28, 2022
PanAeon pushed a commit to PanAeon/vscode-scala-syntax that referenced this issue Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants