[PROOF-OF-CONCEPT/DO NOT MERGE] Avoid forcing type aliases to get their typeParams #981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a strawman proposal for fixing #970, before this commit, the
following failed with a cyclic reference error:
where B.scala is defined as:
Here's what I think is happening:
(
Scala2Unpickler#readType
)type parameters.
(
TypeApplications#appliedTo
andTypeApplications#typeParams
)the TypeAlias, this requires completing the TypeAlias.
forces us to typecheck its right-hand side.
(
Namer#Completer#typeSig
)themselves refer indirectly to type aliases, forcing even more
stuff.
This commit is a hacky way to avoid 3. by only completing the type parameters
of a type alias instead of completing the whole type alias when we don't
need it. Let me know if you think the basic idea is sound or not and if
you can think of a nicer way to implement it!
CC @odersky