Change early typeparams #1027
Closed
Change early typeparams #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to rebase over current master. |
containsRefinedThis inspects symbols and infos of named types in order to avoid needless traversals. As i974 shows, this can lead to infinite recursions. The fix is not to force a NamedType denotation, assume the worst and traverse the prefix if a NamedType is not yet populated with a denotation. Fixes scala#974 and makes MutableSortedSetFactory in stdlib compile.
Need to also look info refined types. Need to handle case where we hit a NoCompleter again.
I observed in a local partest a file with was a java.io.Path, not an SFile. They should be treated like SFiles. Not clear why this came up. The file in question (partest-generated/pos/Patterns_v1.scala) looked just like all the others that were read as SFiles.
Through substitutions we might end up with code like
C[hk0 = T] # Apply
where C is a non-lambda class. This case has to be handled specially.
If we don't do that, we get a stackoverflow when compiling IndexedSeq.
Type params should be computed before computing the whole info of a type. Without the patch we get a cycluc reference in the compileMixed test.
odersky
force-pushed
the
change-early-typeparams
branch
from
2c9d78c to
ee5c9db
Compare
|
The rebase ate my comment so to recap: dotty-staging@5f1e298 is not needed on master, it's only needed because dotty-staging@beb6fce is applied so I wonder if there's a bug in dotty-staging@beb6fce and I'd be in favor of reverting it since it's not needed anymore to avoid cyclic references (cf. #1026 (comment)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.