-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #9246 and #6800: Remove pure statements #9263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
package dotty.tools.dotc | ||
package transform | ||
|
||
import ast.{Trees, tpd} | ||
import core._, core.Decorators._ | ||
import MegaPhase._ | ||
import Types._, Contexts._, Flags._, DenotTransformers._ | ||
import Symbols._, StdNames._, Trees._ | ||
|
||
object PureStats { | ||
val name: String = "pureStats" | ||
} | ||
|
||
/** Remove pure statements in blocks */ | ||
class PureStats extends MiniPhase { | ||
|
||
import tpd._ | ||
|
||
override def phaseName: String = PureStats.name | ||
|
||
override def runsAfter: Set[String] = Set(Erasure.name) | ||
|
||
override def transformBlock(tree: Block)(implicit ctx: Context): Tree = | ||
val stats = Trees.flatten( | ||
tree.stats.mapConserve { | ||
case Typed(Block(stats, expr), _) if isPureExpr(expr) => Thicket(stats) | ||
case stat if !stat.symbol.isConstructor && isPureExpr(stat) => EmptyTree | ||
case stat => stat | ||
}) | ||
cpy.Block(tree)(stats, tree.expr) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since you're using val stats = tree.stats.mapConserve { ... }
if stats eq tree.stats then tree
else cpy.Block(tree)(Trees.flatten(stats), tree.expr) |
||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation copies all blocks which leads in practice to large scale tree rewriting & allocation even if there are no pure statements. I'd try this instead:
(flatten avoids tree copying if possible).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That variant works well