Fix #9246 and #6800: Remove pure statements #9263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 30, 2020
smarter
reviewed
Jun 30, 2020
odersky
requested changes
Jul 1, 2020
| case Typed(Block(stats, expr), _) if isPureExpr(expr) => stats | ||
| case stat => if !stat.symbol.isConstructor && isPureExpr(stat) then Nil else List(stat) | ||
| } | ||
| cpy.Block(tree)(stats, tree.expr) |
There was a problem hiding this comment.
This implementation copies all blocks which leads in practice to large scale tree rewriting & allocation even if there are no pure statements. I'd try this instead:
val stats = Trees.flatten(
tree.stats.mapConserve {
case Typed(Block(stats, expr), _) if isPureExpr(expr) => Thicket(stats)
case stat if !stat.symbol.isConstructor && isPureExpr(stat) => EmptyTree
case stat => stat
})(flatten avoids tree copying if possible).
There was a problem hiding this comment.
That variant works well
odersky
approved these changes
Jul 1, 2020
allanrenucci
reviewed
Jul 1, 2020
| case stat if !stat.symbol.isConstructor && isPureExpr(stat) => EmptyTree | ||
| case stat => stat | ||
| }) | ||
| cpy.Block(tree)(stats, tree.expr) |
There was a problem hiding this comment.
Since you're using mapConserve you may not need to call Trees.flatten and cpy.Block:
val stats = tree.stats.mapConserve { ... }
if stats eq tree.stats then tree
else cpy.Block(tree)(Trees.flatten(stats), tree.expr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.