Fix some mistakes in the Match Types documentation #8706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Apr 10, 2020
iamrecursion
force-pushed
the
wip/ara/match-types-doc-tweaks
branch
from
7a8f314 to
fceb470
Compare
|
I should note that formatting and line wrapping seems to be a bit inconsistent throughout the documentation, so I just went with a sensible default for that. If those changes are unwelcome I'm very happy to revert them and just leave the spelling / grammatical tweaks! |
OlivierBlanvillain
approved these changes
Apr 15, 2020
1. Fix a few spelling and grammar errors in the match types documentation. 2. Add a comment reflecting the work to be done as part of scala#8702 so readers of the documentation do not gain a mistaken understanding of the variance rules for Match Types. 3. Wraps lines at 80 characters to enable much easier reading of the documentation in its source form. Review by @OlivierBlanvillain
iamrecursion
force-pushed
the
wip/ara/match-types-doc-tweaks
branch
from
fceb470 to
ba3aa8c
Compare
|
Fixed! Thanks for the review, and it's been great to watch all the work on match types. Is there any way I can get involved? |
|
Thanks! 8649 could be a good (match type related) first issue if you want to get your hands in the compiler internals |
|
Thanks for the pointer! I think I should have a chance to take a look at it this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't associated with any ticket, but just comes from the fact that I'm following the work on match types! It's really cool to see how they're evolving, and I'm interested in getting more involved.
Review by @OlivierBlanvillain