Skip to content

Update documentation on Variance Laws for Match Types #8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OlivierBlanvillain opened this issue Apr 9, 2020 · 0 comments · Fixed by #13628
Closed

Update documentation on Variance Laws for Match Types #8702

OlivierBlanvillain opened this issue Apr 9, 2020 · 0 comments · Fixed by #13628
Assignees
@OlivierBlanvillain
Labels
area:documentation area:match-types

Comments

@OlivierBlanvillain
Copy link
Contributor

The current documentation doesn't reflect the implementation, for instance, type parameters in pattern position are invariant and not contravarant.
@OlivierBlanvillain OlivierBlanvillain self-assigned this Apr 9, 2020
iamrecursion added a commit to iamrecursion/dotty that referenced this issue Apr 10, 2020
@iamrecursion
Fix some mistakes in the Match Types documentation
7a8f314 
1. Fix a few spelling and grammar errors in the match types
   documentation.
2. Add a comment reflecting the work to be done as part of scala#8702 so
   readers of the documentation do not gain a mistaken understanding of
   the variance rules for Match Types.

Review by @OlivierBlanvillain
@iamrecursion iamrecursion mentioned this issue Apr 10, 2020
Merged
iamrecursion added a commit to iamrecursion/dotty that referenced this issue Apr 10, 2020
@iamrecursion
Fix some mistakes in the Match Types documentation
fceb470 
1. Fix a few spelling and grammar errors in the match types
   documentation.
2. Add a comment reflecting the work to be done as part of scala#8702 so
   readers of the documentation do not gain a mistaken understanding of
   the variance rules for Match Types.
3. Wraps lines at 80 characters to enable much easier reading of the
   documentation in its source form.

Review by @OlivierBlanvillain
iamrecursion added a commit to iamrecursion/dotty that referenced this issue Apr 16, 2020
@iamrecursion
Fix some mistakes in the Match Types documentation
ba3aa8c 
1. Fix a few spelling and grammar errors in the match types
   documentation.
2. Add a comment reflecting the work to be done as part of scala#8702 so
   readers of the documentation do not gain a mistaken understanding of
   the variance rules for Match Types.
3. Wraps lines at 80 characters to enable much easier reading of the
   documentation in its source form.

Review by @OlivierBlanvillain
OlivierBlanvillain added a commit to dotty-staging/dotty that referenced this issue Sep 28, 2021
@OlivierBlanvillain
Fix scala#8702: Update outdated paragraph on MT variance
31d3268 
The added test case details the current state, which we only very
briefly summarized in the documentation.
OlivierBlanvillain added a commit to dotty-staging/dotty that referenced this issue Sep 28, 2021
@OlivierBlanvillain
Fix scala#8702: Update outdated paragraph on MT variance
5635f7b 
The added test case shows how the current implementation handles variance of match types. This PR updates the correponding documentation which was outdated.
OlivierBlanvillain added a commit to dotty-staging/dotty that referenced this issue Sep 28, 2021
@OlivierBlanvillain
Fix scala#8702: Update outdated paragraph on MT variance
b8443f2 
The added test case shows how the current implementation handles variance of match types. This PR updates the correponding documentation which was outdated.
@OlivierBlanvillain OlivierBlanvillain linked a pull request Sep 28, 2021 that will close this issue
Fix #8702: Update outdated paragraph on MT variance #13628
Merged
OlivierBlanvillain added a commit to dotty-staging/dotty that referenced this issue Oct 13, 2021
@OlivierBlanvillain
Fix scala#8702: Update outdated paragraph on MT variance
222dc19 
The added test case shows how the current implementation handles variance of match types. This PR updates the correponding documentation which was outdated.
danicheg pushed a commit to danicheg/dotty that referenced this issue Oct 21, 2021
@OlivierBlanvillain @danicheg
Fix scala#8702: Update outdated paragraph on MT variance
8a92895 
The added test case shows how the current implementation handles variance of match types. This PR updates the correponding documentation which was outdated.
olsdavis pushed a commit to olsdavis/dotty that referenced this issue Apr 4, 2022
@OlivierBlanvillain @olsdavis
Fix scala#8702: Update outdated paragraph on MT variance
e4ad470 
The added test case shows how the current implementation handles variance of match types. This PR updates the correponding documentation which was outdated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlivierBlanvillain OlivierBlanvillain

Labels
area:documentation area:match-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #8702: Update outdated paragraph on MT variance dotty-staging/dotty
2 participants
@smarter @OlivierBlanvillain