Skip to content

Better cleanup strategy for GH Actions CI #8618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Better cleanup strategy for GH Actions CI #8618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 56 additions & 14 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,14 @@ jobs:
container: akmetiuk/dotty:2020-02-12

steps:
- name: Clean Workspace
uses: anatoliykmetyuk/[email protected]
- name: Cleanup
run: |
TARGETS="$(pwd) /__w/_temp /github/home"
for folder in $TARGETS; do
echo "Cleaning $folder"
cd $folder
rm -rf ..?* .[!.]* *
done

- name: Git Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -52,8 +58,14 @@ jobs:
container: akmetiuk/dotty:2020-02-12

steps:
- name: Clean Workspace
uses: anatoliykmetyuk/[email protected]
- name: Cleanup
run: |
TARGETS="$(pwd) /__w/_temp /github/home"
for folder in $TARGETS; do
echo "Cleaning $folder"
cd $folder
rm -rf ..?* .[!.]* *
done

- name: Git Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -89,8 +101,14 @@ jobs:
container: akmetiuk/dotty:2020-02-12

steps:
- name: Clean Workspace
uses: anatoliykmetyuk/[email protected]
- name: Cleanup
run: |
TARGETS="$(pwd) /__w/_temp /github/home"
for folder in $TARGETS; do
echo "Cleaning $folder"
cd $folder
rm -rf ..?* .[!.]* *
Comment on lines +109 to +110
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Suggested change
cd $folder
rm -rf ..?* .[!.]* *
rm -rf $folder
mkdir $folder

Copy link
Contributor Author

@anatoliykmetyuk anatoliykmetyuk Mar 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original version works well enough: it cleans up both hidden and non-hidden files. The problem with deleting the folders is that if they are mounted by Docker, we might get the "device is busy" error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably factor this out in a script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tricky with the current setup. CIs are surprisingly bad at modularisation, neither Drone nor GH Actions doesn't allow to save steps under a name and then refer to them later. I'll merge this FTTB since this is quite high prio.

done

- name: Git Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -132,8 +150,14 @@ jobs:
github.event_name == 'schedule'

steps:
- name: Clean Workspace
uses: anatoliykmetyuk/[email protected]
- name: Cleanup
run: |
TARGETS="$(pwd) /__w/_temp /github/home"
for folder in $TARGETS; do
echo "Cleaning $folder"
cd $folder
rm -rf ..?* .[!.]* *
done

- name: Git Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -172,8 +196,14 @@ jobs:
github.event_name == 'schedule'

steps:
- name: Clean Workspace
uses: anatoliykmetyuk/[email protected]
- name: Cleanup
run: |
TARGETS="$(pwd) /__w/_temp /github/home"
for folder in $TARGETS; do
echo "Cleaning $folder"
cd $folder
rm -rf ..?* .[!.]* *
done

- name: Git Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -217,8 +247,14 @@ jobs:
SONATYPE_USER: ${{ secrets.SONATYPE_USER }}

steps:
- name: Clean Workspace
uses: anatoliykmetyuk/[email protected]
- name: Cleanup
run: |
TARGETS="$(pwd) /__w/_temp /github/home"
for folder in $TARGETS; do
echo "Cleaning $folder"
cd $folder
rm -rf ..?* .[!.]* *
done

- name: Git Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -260,8 +296,14 @@ jobs:
# Make sure you have the write permissions to the repo: https://github.com/lampepfl/dotty-website

steps:
- name: Clean Workspace
uses: anatoliykmetyuk/[email protected]
- name: Cleanup
run: |
TARGETS="$(pwd) /__w/_temp /github/home"
for folder in $TARGETS; do
echo "Cleaning $folder"
cd $folder
rm -rf ..?* .[!.]* *
done

- name: Git Checkout
uses: actions/checkout@v2
Expand Down