Better cleanup strategy for GH Actions CI #8618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before each GH Actions job, remove everything from: - The working directory (where the Dotty repo is cloned) - The temp directory - The user home directory These directories are mounted by Docker before the workflow is started and hence can be persisted between different CI runs and we don't want that. The list of the directories can be obtained by looking at the `docker create` command that the "Initialize containers" step runs for each job of the CI. Only volumes that are vital for CI functioning are spared during the cleanup.
smarter
reviewed
Mar 26, 2020
Comment on lines
+109
to
+110
| cd $folder | ||
| rm -rf ..?* .[!.]* * |
There was a problem hiding this comment.
How about:
Suggested change
| cd $folder | |
| rm -rf ..?* .[!.]* * | |
| rm -rf $folder | |
| mkdir $folder |
There was a problem hiding this comment.
I think the original version works well enough: it cleans up both hidden and non-hidden files. The problem with deleting the folders is that if they are mounted by Docker, we might get the "device is busy" error.
There was a problem hiding this comment.
We should probably factor this out in a script
There was a problem hiding this comment.
It's tricky with the current setup. CIs are surprisingly bad at modularisation, neither Drone nor GH Actions doesn't allow to save steps under a name and then refer to them later. I'll merge this FTTB since this is quite high prio.
nicolasstucki
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before each GH Actions job, remove everything from:
These directories are mounted by Docker before the workflow
is started and hence can be persisted between different CI
runs and we don't want that. The list of the directories can be obtained by looking at the
docker createcommandthat the "Initialize containers" step runs for each job of
the CI. Only volumes that are vital for CI functioning are
spared during the cleanup.