Skip to content

Fix #8501: Disable failing test #8518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

anatoliykmetyuk
Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk commented Mar 11, 2020

The test in question was introduced by #8386. The test
was failing on Java 11 from the very first time it was
introduced. The first commit where
testCompilation context-functions fails under Java 11 is
cbd21a0.

The test was added a few commits prior on 0f41cea, but that one fails to compile.

The test in question was introduced by scala#8386. The test
was failing on Java 11 from the very first time it was
introduced. The first commit where
`testCompilation context-functions` fails under Java 11 is
cbd21a0.
@anatoliykmetyuk anatoliykmetyuk linked an issue Mar 11, 2020 that may be closed by this pull request
@anatoliykmetyuk anatoliykmetyuk self-assigned this Mar 11, 2020
@nicolasstucki nicolasstucki requested a review from smarter March 11, 2020 15:27
@nicolasstucki
Copy link
Contributor

This would deserve another issue to be opened for that failing test

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Nicolas, we shouldn't release with a regression in Java 11.

@anatoliykmetyuk
Copy link
Contributor Author

I think we should disable it FTTB so that to unblock nightlies.

@smarter
Copy link
Member

smarter commented Mar 11, 2020

I have a proper fix: #8519

@smarter smarter closed this Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed nightly test with Java 11
3 participants