Skip to content

Failed nightly test with Java 11 #8501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolasstucki opened this issue Mar 11, 2020 · 8 comments
Closed

Failed nightly test with Java 11 #8501

nicolasstucki opened this issue Mar 11, 2020 · 8 comments
Assignees
@anatoliykmetyuk

Comments

@nicolasstucki
Copy link
Contributor

Nightly build failed tests/run/context-functions.scala with Java 11.

https://dotty-ci.epfl.ch/lampepfl/dotty/4916/1/7

Restarted test: https://dotty-ci.epfl.ch/lampepfl/dotty/4918
@nicolasstucki
Copy link
Contributor Author

@anatoliykmetyuk this might be a blocker for #8496

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Mar 11, 2020 •
edited
Loading

Actually it first failed in https://dotty-ci.epfl.ch/lampepfl/dotty/4798

@smarter
Copy link
Member

smarter commented Mar 11, 2020

probably caused by #8452. Not sure what's going on but I don't really understand why a mini-phase is a better fix than not doing an expansion when the expected type of an implicit function type is the same function type.

@anatoliykmetyuk
Copy link
Contributor

Actually it first failed in https://dotty-ci.epfl.ch/lampepfl/dotty/4798

Yeah, no nightlies have been published since 6th March: https://repo1.maven.org/maven2/ch/epfl/lamp/dotty-compiler_0.23/

@anatoliykmetyuk
Copy link
Contributor

anatoliykmetyuk commented Mar 11, 2020 •
edited
Loading

It seems that it is caused by #8386. The failing test in question was added in that PR and was failing on Java 11 from the very time it was introduced. The first commit where testCompilation context-functions fails under Java 11 is cbd21a0.

/cc @odersky

anatoliykmetyuk added a commit to dotty-staging/dotty that referenced this issue Mar 11, 2020
@anatoliykmetyuk
Fix scala#8501: Disable failing test
2c6614e 
The test in question was introduced by scala#8386. The test
was failing on Java 11 from the very first time it was
introduced. The first commit where
`testCompilation context-functions` fails under Java 11 is
cbd21a0.
@anatoliykmetyuk anatoliykmetyuk linked a pull request Mar 11, 2020 that will close this issue
Fix #8501: Disable failing test #8518
Closed
@smarter
Copy link
Member

smarter commented Mar 11, 2020

Note that the this test runs correctly under Java 11 with a nightly from before #8386 so it is a regression.

@anatoliykmetyuk
Copy link
Contributor

anatoliykmetyuk commented Mar 11, 2020 •
edited
Loading

This test did not exist before #8386, it never worked under Java 11. If you run it manually before #8386 though, it does work properly.

@smarter
Copy link
Member

smarter commented Mar 11, 2020

If you run it manually before #8386 though, it does work properly.

Yes, that's what I meant.

smarter added a commit to dotty-staging/dotty that referenced this issue Mar 11, 2020
@smarter
Fix scala#8501: Run closure adaptation in Erasure.etaExpand
b63f878 
Erasure.Boxing.etaExpand generates closures, but did not run the same closure
adaptation code used in Erasure#typedClosure which could lead to
type mismatches at runtime when invoking it. Fixed by moving out the
adaptation logic from Erasure#typedClosure into
Erasure.Boxing.adaptClosure and reusing this in
Erasure.Boxing.etaExpand.

This fixes tests/run/context-functions.scala on Java 11.
smarter added a commit that referenced this issue Mar 11, 2020
@smarter
Merge pull request #8519 from dotty-staging/adapt-shortcut-closure
a2354a8 
Fix #8501: Run closure adaptation in Erasure.etaExpand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatoliykmetyuk anatoliykmetyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #8501: Disable failing test dotty-staging/dotty
3 participants
@smarter @anatoliykmetyuk @nicolasstucki