Skip to content

Add quoted.{Lifted,Unlifted} #8513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add quoted.{Lifted,Unlifted} #8513

wants to merge 1 commit into from

Conversation

nicolasstucki
Copy link
Contributor

As a dual of lifting (Expr.apply), unliftings should be placed consis

  • Move Values.unapply to Unlifted.unapply
  • Move Value.unapply to Unlifted.unapply(Seq)
  • Move Expr.unapply to Lifted.unapply

This is an alternative to #8504

  • (+) Provides an interface with names that match closely the concepts
  • (+) Semantic difference between '{ ... } and Lifted(...) (previously Expr(...)) is clearer
  • (-) Migration cost for deprecated Expr.apply to Lifted.apply

@nicolasstucki nicolasstucki self-assigned this Mar 11, 2020
@nicolasstucki nicolasstucki mentioned this pull request Mar 11, 2020
Closed
@nicolasstucki
Add quoted.{Lifted,Unlifted}
68e1933 
As a dual of lifting (Expr.apply), unliftings should be placed consistent namespaces.

* Move `Values.unapply to `Unlifted.unapply`
* Move `Value.unapply` to `Unlifted.unapply(Seq)`
* Move `Expr.unapply` to `Lifted.unapply`
@nicolasstucki nicolasstucki force-pushed the homogenlze-liftable-unliftable-api branch from 822be89 to 68e1933 Compare March 11, 2020 13:55
@nicolasstucki nicolasstucki changed the title As a dual of lifting (Expr.apply), unliftings should be placed consis Add quoted.{Lifted,Unlifted} Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun Awaiting requested review from liufengyun

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicolasstucki