Add quoted.Exprs and move Value(s) into Expr(s) #8504
Conversation
nicolasstucki
force-pushed
the
add-quoted-exprs
branch
2 times, most recently
from
a132c48 to
0dfa827
Compare
As a dual of lifting (`Expr.apply`), unliftings should be placed in the same namespace (`Expr.unapply`). * Move `Values.unapply` to `Exprs.unapply` * Move `Value.unapply` to `Expr.unapply` * Add `Exprs.apply`
nicolasstucki
force-pushed
the
add-quoted-exprs
branch
from
0dfa827 to
e023fc7
Compare
nicolasstucki
changed the title
| @@ -617,7 +617,7 @@ It is possible to deconstruct or extract values out of `Expr` using pattern matc | |||
| `scala.quoted` contains objects that can help extracting values from `Expr`. | |||
|
|
|||
| * `scala.quoted.Const`/`scala.quoted.Consts`: matches an expression of a literal value (or list of values) and returns the value (or list of values). | |||
| * `scala.quoted.Value`/`scala.quoted.Values`: matches an expression of a value (or list of values) and returns the value (or list of values). | |||
| * `scala.quoted.Expr`/`scala.quoted.Exprs`: matches an expression of a value (or list of values) and returns the value (or list of values). | |||
There was a problem hiding this comment.
This is not intuitive --- Expr and values are very different, conceptually.
There was a problem hiding this comment.
If we say that Expr(x) takes a value and lifts it into and Expr, then case Expr(x) => takes the value out of the expression. It seems really intuitive but may need to be explained in a better way.
There was a problem hiding this comment.
Maybe unlift, to align with Unliftable?
There was a problem hiding this comment.
Then we would need to move Expr.apply to Lift.apply (or Lifted.apply). This would break a lot of code.
In a patterns Unlifted works better, which is a bit too long.
There was a problem hiding this comment.
I will open a PR with the alternative
There was a problem hiding this comment.
See #8513. It does look semantically clearer. But has migration costs (a deprecation warining).
As a dual of lifting (
Expr.apply), unliftings should be placed in the same namespace(
Expr.unapply).Values.unapplytoExprs.unapplyValue.unapplytoExpr.unapplyExprs.apply