Skip to content

doc(extension method): revise examples #8508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 6, 2020

Conversation

robstoll
Copy link
Contributor

@robstoll robstoll commented Mar 11, 2020

On purpose not in #8507 as it contains more changes than usual and the chances are higher that we need to discuss them.

@odersky odersky self-assigned this Mar 23, 2020
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. It's great to see these improvements!

@robstoll
Copy link
Contributor Author

robstoll commented Mar 31, 2020

@odersky I still have to fix the mistake with bringing divide into scope (which is not even an extension method). So please don't merge yet. I thought I wait until I get a feedback from you (or any other) concerning the simple name rule which seems to be a simplification in my point of view. IMO we don't need to be very specific in the docs about this minor detail as people using simple names won't have problems. However, I would suggest that we state something along the line of Using a qualified name for the receiver of an extension method might work for certain cases but should be seen as experimental and could change at any time. What do you think?

Edit not necessary, I confused myself, the under a simple name is actually fine. I am going to add my insights to the documentation and do the remaining improvements.

@robstoll
Copy link
Contributor Author

Did the last adjustments, good to merge IMO

@odersky
Copy link
Contributor

odersky commented Apr 6, 2020

Thank you for the contribution!

@odersky odersky merged commit 24672e6 into scala:master Apr 6, 2020
@robstoll robstoll deleted the doc-extension-method branch May 1, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants