-
Notifications
You must be signed in to change notification settings - Fork 1.1k
different documation improvments #8507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc(adt): link to enum
doc(enum): typo
doc(dependent-fun): typo
Doc match type
doc(type-lamba): remove superfluous `construct`
doc(opaques-details): typo
doc(match-type): fix type lambda syntax
doc(opaque type alias): revise text, remove workaround
doc(type-lambda): typos and improvements
doc(givens): mention thread safety
smarter
requested changes
Mar 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for bunching them up, that works well for reviewing I think! And these are some really nice changes too!
smarter
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed upon in #8381 (comment) I have merged several branches into one branch and make the PR now. As I am doing most of my PRs on my mobile phone it is really just a compromise. It means quite a bit more work for me as I need to check if the branch is up-to-date, fetch new changes (which I have to do on a PC and not on my mobile) etc.
Please let me know in case this form of the PR is not what you are looking for either. I am more than happy to switch back to small PRs per page