Skip to content

Simplify import of tasty unseal #8441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

Make the reflection API not require the given import import qctx.tasty.{given _}. import qctx.tasty._ is still used but not required

@nicolasstucki nicolasstucki force-pushed the simplify-import-of-tasty-unseal branch 3 times, most recently from 972deb2 to ef3f7ed Compare March 4, 2020 21:32
@nicolasstucki nicolasstucki self-assigned this Mar 4, 2020
@nicolasstucki nicolasstucki requested a review from liufengyun March 4, 2020 21:37
@nicolasstucki nicolasstucki force-pushed the simplify-import-of-tasty-unseal branch from ef3f7ed to 81a0814 Compare March 5, 2020 20:51
@nicolasstucki nicolasstucki force-pushed the simplify-import-of-tasty-unseal branch from 81a0814 to fff7050 Compare March 5, 2020 21:06
@nicolasstucki nicolasstucki marked this pull request as ready for review March 6, 2020 06:14
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 83e6270 into scala:master Mar 6, 2020
@nicolasstucki nicolasstucki deleted the simplify-import-of-tasty-unseal branch March 6, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants