Simplify import of qctx.tasty.rootContext #8438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `rootContext` with `import qctx.tasty._` (no given import)
nicolasstucki
changed the title
liufengyun
approved these changes
Mar 5, 2020
| @@ -452,7 +452,8 @@ class Reflection(private[scala] val internal: CompilerInterface) { self => | |||
| ////////////// | |||
|
|
|||
| /** Context of the macro expansion */ | |||
| given rootContext as Context = internal.rootContext // TODO: Use given // TODO: Should this be moved to QuoteContext? | |||
| def rootContext: Context = internal.rootContext // TODO: Should this be moved to QuoteContext? | |||
| given Context = rootContext // TODO: Should be an implicit converion from QuoteContext to Context | |||
There was a problem hiding this comment.
This change seems not useful.
There was a problem hiding this comment.
It is to be able to access the rootContext by name when only importing import qctx.tasty._ , otherwise it is only visible with the given import.
There was a problem hiding this comment.
Nothing changed for summoning it
| @@ -11,7 +11,7 @@ object SourceFiles { | |||
|
|
|||
| def getThisFileImpl: Macro[String] = { | |||
| val qctx = tastyContext | |||
| import qctx.tasty.{_, given _} | |||
| import qctx.tasty._ | |||
There was a problem hiding this comment.
We have many such cases in the test set, change them too?
There was a problem hiding this comment.
We still need to adapt unseal to be able to change them all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
rootContextwithimport qctx.tasty._(no given import)This takes advantage of the change introduced in #8410