Emit an error instead of crashing on incorrect Java annotation; support non-literal annot params with constant types #7495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
java-annots-neg
branch
from
6609b2e to
de050de
Compare
smarter
changed the title
This is similar to the error that scalac emits, though it emits at typer instead of backend.
smarter
force-pushed
the
java-annots-neg
branch
from
de050de to
5ba2e49
Compare
odersky
approved these changes
Nov 6, 2019
|
LGTM. Maybe @lrytz could also have a look at it. |
|
LGTM, seems similar to what scalac does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.