Port Constant Types for Literal Final Static Java Fields and Implicit Conversions from Scalac #7483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Nov 1, 2019
Not sure I understand, what error are you seeing with that test exactly ? |
|
@smarter Here is the code which triggers the same error:
import java.lang.annotation.*;
@Retention(RetentionPolicy.RUNTIME)
public @interface J {
String value();
}
object C {
val cs: String = "cs"
}
object S {
@J(C.cs)
def f(): Int = 1
}
|
|
That code emits a "annotation argument is not a constant" in scalac, I've just created a PR to do the same for dotty: #7495 |
|
@smarter Thanks for the crash fix! However, with this fix, the annotation arguments still cannot be constants. That's why I am not able to port the test of SI-3236. |
|
OK, I've pushed an extra commit to #7495 which handles this. |
|
If you rebase on master you should be able to add these tests now. |
|
@smarter Thanks, the SI-3236 test is now added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
ClassParserwill giveConstantTypes to constant fields, but theJavaParserwill not, because theJavaParserin Dotty doesn’t parse the expressions of fields. This PR ports the parsing literals part from Scalac, so thatConstantTypes will be assigned to constant Java fields with simple literals.SI-3236 constant types for literal final static java fields
scala/scala@81d2c61
Support implicit converstions from java literals
scala/scala@74c613b
This is also useful for the explicit nulls #6344. With this feature, we don’t need to nullify constant fields.
I am not able to port the test of SI-3236 directly, since the annotation arguments in Dotty can only refers to enum values (in
DottyBackendInterface.emitArgument)? If I’m wrong, please correct me.Edit: The SI-3236 test is now ported.