Fix implicit scope implementation #6832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
fix-implicit-scope
branch
4 times, most recently
from
3d5bf8d to
aa4aee6
Compare
odersky
changed the title
odersky
force-pushed
the
fix-implicit-scope
branch
from
8c77860 to
93b4832
Compare
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/6832/ to see the changes. Benchmarks is based on merging with master (15b9cd8) |
odersky
force-pushed
the
fix-implicit-scope
branch
from
93b4832 to
60a9c96
Compare
milessabin
reviewed
Jul 16, 2019
| val companion = sym.companionModule | ||
| if (companion.exists) addRef(companion.termRef) | ||
| def addCompanion(pre: Type, companion: Symbol) = | ||
| if (companion.exists && !companion.isAbsent) comps += TermRef(pre, companion) |
There was a problem hiding this comment.
Use of isAbsent here breaks after #6842.
There was a problem hiding this comment.
What do you mean by break ? The signature of isAbsent changed, so at the very least you need to add parens to it: isAbsent()
There was a problem hiding this comment.
Well, yes, precisely :-)
Maybe my terminology is off here, but no git conflict, CI passes, yet will fail if merged.
The previous implicit scope was hard to understand, and did not conform to spec. The new implementation is simpler to understand. It also does not conform to spec as written but there's a chance that we might change the spec to conform to it.
odersky
force-pushed
the
fix-implicit-scope
branch
from
60a9c96 to
fd3edbd
Compare
|
LGTM. Also verified that the technique proposed to fix shapeless after this change will work. |
milessabin
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change implicit scope implementation so that it can be understood and adapted to different strategies.
Based on #6824. First new commit is aa4aee6.