Skip to content

Three tweaks #6824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2019
Merged

Three tweaks #6824

merged 4 commits into from
Jul 11, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jul 9, 2019 •
edited
Loading

  1. Treat val _ = ... as a PatDef, which enables multiple such definitions without double definition errors.
  2. Specialize types of inline values even if a wider type was given in an inherited definition. This generalizes a previous scheme for final vals.
  3. Fix Scala2 unpickler's handling of package references

odersky added 3 commits July 8, 2019 21:27
@odersky
Handle multiple val _ = ... definitions
e52ac88 
These need to be expanded to pattern definitions, not ValDefs,
otherwise duplicate definition errors result.
@odersky
Specialize types of inline values
38e47df 
Specialize types of ibline values even if a wider type was gven in an inherited definition.
This generalizes a previous scheme for final vals.
@odersky
Fix Scala2 unpickler's handling of package references
98e0404
@odersky odersky changed the title Two tweaks Three tweaks Jul 10, 2019
@odersky odersky mentioned this pull request Jul 10, 2019
Merged
liufengyun
liufengyun approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit ca5916e into scala:master Jul 11, 2019
@liufengyun liufengyun deleted the specialize-inline-vals branch July 11, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @liufengyun