Skip to content

Cleanup --from-tasty blacklists #6420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions compiler/test/dotc/pos-from-tasty.blacklist
Original file line number Diff line number Diff line change
@@ -1,26 +1,5 @@
# Wrong number of arguments (only on bootstrapped)
i3130b.scala

# Missing position
# has location not matching its contents: contains class mixins.Collections
collections_1.scala

# MatchError in SymDenotation.sourceModule on a ThisType
# Infinite loop
t3612.scala

# Fails on MacOS
annot-bootstrap.scala

# ScalaRunTime cannot be unpickled because it is already loaded
repeatedArgs213.scala

# Error printing parent constructors that are blocks
default-super.scala

# Did not survive addition of type ascriptions in decompiled tests
i3050.scala
i4006b.scala
i4006c.scala

# Not sure what's wring here
i4203.scala
t6278-synth-def.scala
3 changes: 0 additions & 3 deletions compiler/test/dotc/run-from-tasty.blacklist
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
# Closure type miss match
eff-dependent.scala

# It seems we still harmonize types in fromTasty. Not sure where this happens
puzzle.scala

# We get: class Foo needs to be abstract, since implicit val x$1: TC is not defined
i2567.scala
4 changes: 3 additions & 1 deletion compiler/test/dotty/tools/TestSources.scala
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ object TestSources {
.filter(_.nonEmpty)
.toList

assert(list.nonEmpty)
if (list.isEmpty)
println(s"$path is empty")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to remove all blacklisted item and run the tests to see which one actually fail.


list
}

Expand Down