Skip to content

Cleanup --from-tasty blacklists #6420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@@ -43,7 +43,9 @@ object TestSources {
.filter(_.nonEmpty)
.toList

assert(list.nonEmpty)
if (list.isEmpty)
println(s"$path is empty")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to remove all blacklisted item and run the tests to see which one actually fail.

@nicolasstucki nicolasstucki marked this pull request as ready for review May 2, 2019 12:17
Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anatoliykmetyuk anatoliykmetyuk merged commit 9d7d05d into scala:master May 2, 2019
@anatoliykmetyuk anatoliykmetyuk deleted the cleanup-from-tasty-blacklists branch May 2, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants