Skip to content

Show be more verbose when running partest on Jenkins #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/jobs/validate/partest
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ baseDir=${WORKSPACE-`pwd`}
scriptsDir="$baseDir/scripts"
. $scriptsDir/common

sbt $sbtArgs update compile "partest-only run"
sbt $sbtArgs update compile "partest-only run --show-diff --verbose"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally I usually run partest --verbose --show-diff run and the diffs are shown.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smarter the diffs always get shown at the end because of --verbose, what wasn't working was the inline diffs (right where the test fails). It's possible that it works on your machine, partest tries to use git and some other tools to get the best diff it can, so depending on your environment you might get different results.

It seems that the one used for me and some other people doesn't get appended to the test transcript the way the reporting expects, that's why it didn't get printed. The fix is here: #612