Skip to content

Fix --show-diff for partest issue #609 #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2015
Merged

Fix --show-diff for partest issue #609 #612

merged 1 commit into from
May 27, 2015

Conversation

vsalvis
Copy link
Contributor

@vsalvis vsalvis commented May 27, 2015

See issue #609

This was referenced May 27, 2015
Closed
Merged
@DarkDimius
Copy link
Contributor

@vsalvis the errors should go away after you rebase

@vsalvis vsalvis force-pushed the vsalvis-fix-showdiff branch from b2b6443 to b9c3f96 Compare May 27, 2015 20:12
@vsalvis
Copy link
Contributor Author

vsalvis commented May 27, 2015

@DarkDimius done, ready to be merged.

@DarkDimius
Copy link
Contributor

Works on my machine:

[info]
[info] # starting 449 tests in run
[info] !!   1 - run/Course-2002-03.scala                  [output differs]
[info] % diff /Users/dark/workspace/dotty/tests/partest-generated/run/Course-2002-03-run.log /Users/dark/workspace/dotty/tests/partest-generated/run/Course-2002-03.check
[info] %
[info] @@ -1,4 +1,4 @@
[info] -1
[info] +11
[info]  2
[info]  1/2
[info]  5/6
[info]

Hope will also work for others.
LGTM.

DarkDimius added a commit that referenced this pull request May 27, 2015
@DarkDimius
Merge pull request #612 from vsalvis/vsalvis-fix-showdiff
c0b6930 
Fix --show-diff for partest issue #609
@DarkDimius DarkDimius merged commit c0b6930 into scala:master May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsalvis @DarkDimius