Fix/datarace flags

[odersky]

Made FlagTranslation threadsafe, Review by @DarkDimius or @retronym or @vsalvis

[odersky]

/rebuild

[odersky]

The test says "output differs" on one of the run tests. How do get at the log file in jenkins?

[DarkDimius]

@odersky, it's quite involved, you'll need help from either @lrytz or @adriaanm.

[odersky]

Note: I cannot run the tests locally. sbt partest gives:

[error] Test dotc.tests.new_all failed: scala.reflect.io.FileOperationException: File 'arrays.flags' already exists., took 0.008 sec
[error] at scala.reflect.io.Path$.fail(Path.scala:78)
[error] at scala.reflect.io.Path.createFile(Path.scala:235)
[error] at test.CompilerTest.copyFiles(CompilerTest.scala:238)
[error] at test.CompilerTest.computeDestAndCopyFiles(CompilerTest.scala:220)

So it seems we are truly stuck.

[DarkDimius]

ping @vsalvis, see stacktrace in previous comment.

[vsalvis]

Running locally, I get the test failure as well for:
[info] !! 376 - run/t7291.scala [output differs]
The diff is that it prints only "conjure", whereas the check file is

conjure
traversable

I also see spurious failures of pos/tools and pos/io on my machine.

@odersky, can you try manually deleting the /Users/vera/git/dotty/tests/partest-generated/ directory? Do you have uncommitted tests in dotty/tests/new? What does the /Users/vera/git/dotty/tests/partest-generated/gen.log file say in the end (output might be out of order because of parallel JUnit tests)?

[adriaanm]

@DarkDimius, this is a side-effect of how you run partest. You can make it output the diff with --show-diff (https://github.com/scala/scala-partest/blob/3e608c08a80dd8aaece52b2638518b7281fc6c15/src/main/scala/scala/tools/partest/nest/ConsoleRunnerSpec.scala#L38). You can also archive the log files if you prefer as build artifacts (with a variation on: https://github.com/scala/scala-jenkins-infra/blob/master/templates/default/jobs/scala/validate/test.xml.erb#L20).

[retronym]

Here's the corresponding fix for Scalac: scala/scala#2842

[DarkDimius]

@adriaanm, for some reason, --show-diff does not work on Dotty. #609

[DarkDimius]

LGTM, though need to make tests pass, or disable failing tests.

[vsalvis]

Sorry this slipped through, we talked about displaying as much debugging
output as possible because of the difficulties of accessing logs. It
probably makes sense to run partest on Jenkins with "--verbose" to get more
information about failures at the end. --verbose will also display diffs if
there are any, as well as compilation logs if compilation failed.
On May 27, 2015 9:21 AM, "Dmitry Petrashko" [email protected]
wrote:

LGTM, though need to make tests pass, or disable failing tests.

—
Reply to this email directly or view it on GitHub
#607 (comment).

[DarkDimius]

@vsalvis, lets take partest discussion to #609

[odersky]

@vsalvis Thanks for the tip. It was indeed an uncommitted .java file in tests/new. Now I can run partest locally, and get the same test failure you are seeing on run/t7291, both on current master and this branch. Which makes me wonder how master could have succeeded? Do we have flakey run test diagnosis in jenkins, or is it some other problem?

[odersky]

@smarter I did a reorg of disabled after all. It was easier to do it sooner rather than later.