Merge pull request #607 from dotty-staging/fix/datarace-flags

Fix/datarace flags

Author: DarkDimius

src/dotty/tools/dotc/core/classfile/ClassfileConstants.scala

@@ -329,55 +329,50 @@ object ClassfileConstants {
   final val impdep1       = 0xfe
   final val impdep2       = 0xff
 
+  import Flags._
   abstract class FlagTranslation {
-    import Flags._
 
-    private var isAnnotation = false
-    private var isClass      = false
-    private def initFields(flags: Int) = {
-      isAnnotation = (flags & JAVA_ACC_ANNOTATION) != 0
-      isClass      = false
-    }
+    protected def baseFlags(jflags: Int) = EmptyFlags
+    protected def isClass: Boolean = false
 
     private def translateFlag(jflag: Int): FlagSet = (jflag: @switch) match {
       case JAVA_ACC_PRIVATE    => Private
       case JAVA_ACC_PROTECTED  => Protected
       case JAVA_ACC_FINAL      => Final
       case JAVA_ACC_SYNTHETIC  => Synthetic
       case JAVA_ACC_STATIC     => JavaStatic
-      case JAVA_ACC_ABSTRACT   => if (isAnnotation) EmptyFlags else if (isClass) Abstract else Deferred
-      case JAVA_ACC_INTERFACE  => if (isAnnotation) EmptyFlags else PureInterfaceCreationFlags | JavaDefined
+      case JAVA_ACC_ABSTRACT   => if (isClass) Abstract else Deferred
+      case JAVA_ACC_INTERFACE  => PureInterfaceCreationFlags | JavaDefined
       case _                   => EmptyFlags
     }
 
     private def addFlag(base: FlagSet, jflag: Int): FlagSet =
       if (jflag == 0) base else base | translateFlag(jflag)
 
     private def translateFlags(jflags: Int, baseFlags: FlagSet): FlagSet = {
+      val nflags =
+        if ((jflags & JAVA_ACC_ANNOTATION) == 0) jflags
+        else jflags & ~(JAVA_ACC_ABSTRACT | JAVA_ACC_INTERFACE) // annotations are neither abstract nor interfaces
       var res: FlagSet = baseFlags | JavaDefined
-      res = addFlag(res, jflags & JAVA_ACC_PRIVATE)
-      res = addFlag(res, jflags & JAVA_ACC_PROTECTED)
-      res = addFlag(res, jflags & JAVA_ACC_FINAL)
-      res = addFlag(res, jflags & JAVA_ACC_SYNTHETIC)
-      res = addFlag(res, jflags & JAVA_ACC_STATIC)
-      res = addFlag(res, jflags & JAVA_ACC_ABSTRACT)
-      res = addFlag(res, jflags & JAVA_ACC_INTERFACE)
+      res = addFlag(res, nflags & JAVA_ACC_PRIVATE)
+      res = addFlag(res, nflags & JAVA_ACC_PROTECTED)
+      res = addFlag(res, nflags & JAVA_ACC_FINAL)
+      res = addFlag(res, nflags & JAVA_ACC_SYNTHETIC)
+      res = addFlag(res, nflags & JAVA_ACC_STATIC)
+      res = addFlag(res, nflags & JAVA_ACC_ABSTRACT)
+      res = addFlag(res, nflags & JAVA_ACC_INTERFACE)
       res
     }
 
-    def classFlags(jflags: Int): FlagSet = {
-      initFields(jflags)
-      isClass = true
-      translateFlags(jflags, EmptyFlags)
-    }
-    def fieldFlags(jflags: Int): FlagSet = {
-      initFields(jflags)
-      translateFlags(jflags, if ((jflags & JAVA_ACC_FINAL) == 0) Mutable else EmptyFlags)
-    }
-    def methodFlags(jflags: Int): FlagSet = {
-      initFields(jflags)
-      translateFlags(jflags, if ((jflags & JAVA_ACC_BRIDGE) != 0) Bridge else EmptyFlags)
-    }
+    def flags(jflags: Int): FlagSet = translateFlags(jflags, baseFlags(jflags))
+  }
+  val classTranslation = new FlagTranslation {
+    override def isClass = true
+  }
+  val fieldTranslation = new FlagTranslation {
+    override def baseFlags(jflags: Int) = if ((jflags & JAVA_ACC_FINAL) == 0) Mutable else EmptyFlags
+  }
+  val methodTranslation = new FlagTranslation {
+    override def baseFlags(jflags: Int) = if ((jflags & JAVA_ACC_BRIDGE) != 0) Bridge else EmptyFlags
   }
-  object FlagTranslation extends FlagTranslation { }
 }

src/dotty/tools/dotc/core/classfile/ClassfileParser.scala

@@ -89,7 +89,7 @@ class ClassfileParser(
   def parseClass()(implicit ctx: Context): Option[Embedded] = {
     val jflags       = in.nextChar
     val isAnnotation = hasAnnotation(jflags)
-    val sflags       = FlagTranslation.classFlags(jflags)
+    val sflags       = classTranslation.flags(jflags)
     val nameIdx      = in.nextChar
     currentClassName = pool.getClassName(nameIdx)
 
@@ -163,8 +163,8 @@ class ClassfileParser(
     val start = indexCoord(in.bp)
     val jflags = in.nextChar
     val sflags =
-      if (method) Flags.Method | FlagTranslation.methodFlags(jflags)
-      else FlagTranslation.fieldFlags(jflags)
+      if (method) Flags.Method | methodTranslation.flags(jflags)
+      else fieldTranslation.flags(jflags)
     val name = pool.getName(in.nextChar)
     if (!(sflags is Flags.Private) || name == nme.CONSTRUCTOR || ctx.settings.optimise.value) {
       val member = ctx.newSymbol(
@@ -632,7 +632,7 @@ class ClassfileParser(
           getOwner(jflags),
           entry.originalName,
           new ClassfileLoader(file),
-          FlagTranslation.classFlags(jflags),
+          classTranslation.flags(jflags),
           getScope(jflags))
     }
 

tests/disabled/i530-import-symbolic.scala renamed to tests/disabled/pos/i530-import-symbolic.scala

@@ -0,0 +1,19 @@
+object intersection {
+
+  class A
+  class B
+
+  val x: A => Unit = ???
+  val y: B => Unit = ???
+
+  val z = if (???) x else y
+
+  val a: A & B => Unit = z
+  val b: (A => Unit) | (B => Unit) = z
+
+
+
+
+  type needsA = A => Nothing
+  type needsB = B => Nothing
+}

tests/disabled/simplesams.scala renamed to tests/disabled/pos/simplesams.scala

@@ -0,0 +1,8 @@
+// This one blows up with a huge type in Scala 2.
+// Reported by Jon Pretty in his talk on Scala type inference.
+object Test {
+
+  val x = List(List, Vector)
+
+  val y: List[scala.collection.generic.SeqFactory] = x
+}

tests/disabled/t1237.scala renamed to tests/disabled/pos/t1237.scala

@@ -0,0 +1,21 @@
+// Representing the current type
+trait Pet {
+  type This <: Pet
+  def name: String
+  def renamed(newName: String): This
+}
+
+case class Fish(name: String, age: Int) extends Pet {
+  type This = Fish
+  def renamed(newName: String): Fish = copy(name = newName)
+}
+
+case class Kitty(name: String, age: Int) extends Pet {
+  type This = Kitty
+  def renamed(newName: String): Kitty = copy(name = newName)
+}
+
+object Test {
+  def esquire[A <: Pet](a: A): a.This = a.renamed(a.name + ", Esq.")
+  val f: Fish = esquire(new Fish("bob", 22))
+}

tests/disabled/t2669.scala renamed to tests/disabled/pos/t2669.scala

@@ -0,0 +1,7 @@
+object sorting {
+
+  val xs: Array[String] = ???
+
+  java.util.Arrays.sort(xs, ???)
+
+}

tests/disabled/t3174.scala renamed to tests/disabled/pos/t3174.scala

@@ -0,0 +1,7 @@
+object intersection {
+
+  class A
+  class B
+
+  val x: A => Unit = ???
+}