-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #5001: add test #5999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5001: add test #5999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the other two tests in #4820? I.e.
trait Foo[A]
class Bar[A] extends Foo
trait SetOps[A, +C <: SetOps[A, C]] {
def concat(that: Iterable[A]): C = ???
}
class Set1[A] extends SetOps //should be SetOps[A, Set1[A]]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With scalac
:
scala> class Foo extends Any
<console>:11: error: Any does not have a constructor
The code no longer type checks after scala#5027.
Thanks @allanrenucci , it's addressed in the last commit 9a07924 |
`Any` can be parent class of traits, in that case we should choose `AnyRef`.
Addressed in the latest commit.
Fix #5001: add test