Skip to content

Fix #5001: add test #5999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 7, 2019
Merged

Fix #5001: add test #5999

merged 7 commits into from
Mar 7, 2019

Conversation

liufengyun
Copy link
Contributor

Fix #5001: add test

Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the other two tests in #4820? I.e.

trait Foo[A]
class Bar[A] extends Foo
trait SetOps[A, +C <: SetOps[A, C]]  {
  def concat(that: Iterable[A]): C = ???
}

class Set1[A] extends SetOps //should be SetOps[A, Set1[A]]

Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With scalac:

scala> class Foo extends Any
<console>:11: error: Any does not have a constructor

@liufengyun
Copy link
Contributor Author

Thanks @allanrenucci , it's addressed in the last commit 9a07924

`Any` can be parent class of traits, in that case we should
choose `AnyRef`.
@liufengyun liufengyun dismissed allanrenucci’s stale review March 7, 2019 10:11

Addressed in the latest commit.

@liufengyun liufengyun merged commit 8aed4a0 into scala:master Mar 7, 2019
@liufengyun liufengyun deleted the fix-i5001 branch March 7, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants