Fix #5010: check type parents have type arguments #5027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2018
Closed
|
Build failure is spurious. |
odersky
approved these changes
Jan 12, 2019
Blaisorblade
added
stat:needs rebase
fasttrack
We modify t3613 as it was written when AbstractListModel had no type parameter. We could alternatively infer type arguments (see scala/bug#11111), as scalac does, but that seems typically unhelpful. Instead, we only infer them for constructor applications.
Blaisorblade
force-pushed
the
fix-5010-check-parents-have-type-arguments
branch
from
49c19f0 to
16ae587
Compare
liufengyun
added a commit
to dotty-staging/scalatest
that referenced
this pull request
Jan 16, 2019
The following code is no longer supported: class A[T] object A extends A // error: A needs type parameters scala/scala3#5027
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Mar 1, 2019
The code no longer type checks after scala#5027.
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Mar 1, 2019
The code no longer type checks after scala#5027.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modify t3613 as it was written when AbstractListModel had no type parameter.
We could alternatively infer type arguments (see scala/bug#11111), as scalac
does, but that seems typically unhelpful. Instead, we only infer them for
constructor applications.