-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove -Xmax-classfile-name; hard-code to 240, like Scala 2.13.0-RC1 #5872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:
- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
a094b54
to
ba74e70
Compare
a18f324
to
9811e61
Compare
…placed with MaxNameLength and variants hardcoded to 240
9811e61
to
737592f
Compare
Both on latest release and this PR,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does its job correctly; technical debt gets in its way.
I'm happy with this code — but letting @smarter pick the best action. |
7d954bc
to
f3829d1
Compare
Would we want a separate issue for the test failing to compile? Scope of the addressed issue seems to be limited to matching 2.13 |
41eb04a
to
ab68976
Compare
@smarter Is there anything else that needs to be taken care of or is this good for a merge? |
scala/scala#7497 for reference
EDIT: About #5812, doesn't quite fix it.