Remove final keyword from NameOps to explor fix for build failure

IDoCodingStuffs · IDoCodingStuffs · commit ba74e7089493 · 2019-02-08T20:15:05.000-05:00
diff --git a/compiler/src/dotty/tools/dotc/core/NameOps.scala b/compiler/src/dotty/tools/dotc/core/NameOps.scala
@@ -27,7 +27,8 @@ object NameOps {
      */
     def apply(s: String)(implicit ctx: Context): String = {
       val marker = "$$$$"
-      final val LIMIT: Int = 240
+
+      val limit: Int = 240
       val MaxNameLength = (limit - 6) min 2 * (limit - 6 - 2 * marker.length - 32)
 
       def toMD5(s: String, edge: Int): String = {
diff --git a/tests/pending/run/t8199.scala b/tests/pending/run/t8199.scala
@@ -39,7 +39,7 @@ object Test extends dotty.runtime.LegacyApp {
     checkClassName(c.getName)
   }
   def checkClassName(name: String): Unit = {
-    final val MaxSuffixLength = 7 // "$.class".length + 1 // potential module class suffix and file extension
+    final val MaxSuffixLength = 7 // "$.class".length // potential module class suffix and file extension
     final val MaxNameLength   = 240 - MaxSuffixLength
 
     assert((name + ".class").length <= defaultMaxNameLength, name)

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ object Test extends dotty.runtime.LegacyApp {`
`39`	`39`	`checkClassName(c.getName)`
`40`	`40`	`}`
`41`	`41`	`def checkClassName(name: String): Unit = {`
`42`		`- final val MaxSuffixLength = 7 // "$.class".length + 1 // potential module class suffix and file extension`
	`42`	`+ final val MaxSuffixLength = 7 // "$.class".length // potential module class suffix and file extension`
`43`	`43`	`final val MaxNameLength = 240 - MaxSuffixLength`
`44`	`44`
`45`	`45`	`assert((name + ".class").length <= defaultMaxNameLength, name)`