Fix #5578: Refine matches condition #5622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`matches` incorrectly returned a match if two members differed only in their type parameters.
- avoid forcing denotation's info in `matches` - deal with overloaded alternatives in assignType for TypeApply
We might now get more overloaded denotations than before, which only differ in type parameters.
Disambiguation with expected PolyType has to be done not only in the final type, but also in the function part of the tree.
|
Also addresses #5445. |
…ations" This partially reverts 4e695fb which is no longer needed after this PR (scala#5622), because we no longer try to merge in a single denotation a PolyType and a MethodType.
smarter
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matchesincorrectly returned a match if two membersdiffered only in their type parameters.