Workaround #4819: Avoid creating incorrect JointRefDenotations #4829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging a denotation with a PolyType and a denotation with a MethodType, `infoMeet` will return the MethodType info, but the symbol that is then used to create the `JointRefDenotation` can come from either denotation, if it comes from the PolyType one, the resulting denotation is inconsistent, this resulted in RefChecks errors. We fix this by making `preferSym` consistent with `infoMeet`. This is only a workaround and not a proper fix for scala#4819 as it doesn't allow tests/neg/i4819.scala to compile, see the comments in the file.
smarter
force-pushed
the
workaround-overload-merge
branch
from
30718d8 to
4e695fb
Compare
|
With this patch, while compiling the standard library I get: [error] -- Error: /Users/renucci/workspace/scala/src/library/scala/collection/immutable/TreeMap.scala:28:12
[error] 28 |final class TreeMap[K, +V] private (tree: RB.Tree[K, V])(implicit val ordering: Ordering[K])
[error] | ^
[error] |method collect in trait StrictOptimizedMapOps is not a legal implementation of `collect` in class TreeMap
[error] | its type [K2, V2](pf: PartialFunction[(K, V), (K2, V2)]): scala.collection.Map[K2, V2]
[error] | does not conform to [K2, V2](pf: PartialFunction[(K, V), (K2, V2)]): Map[K2, V2]I'll try to minimise Edit: Actually, I think it is another issue. It also happen on master. I opened #4839 |
odersky
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging a denotation with a PolyType and a denotation with a
MethodType,
infoMeetwill return the MethodType info, but the symbolthat is then used to create the
JointRefDenotationcan come fromeither denotation, if it comes from the PolyType one, the resulting
denotation is inconsistent, this resulted in RefChecks errors.
We fix this by making
preferSymconsistent withinfoMeet. This isonly a workaround and not a proper fix for #4819 as it doesn't allow
tests/neg/i4819.scala to compile, see the comments in the file.